From 41ac9971f416ac7897e601aaa8ea14359821fa70 Mon Sep 17 00:00:00 2001 From: MerryMage Date: Sat, 6 Mar 2021 19:35:27 +0000 Subject: [PATCH] thumb32: Implement CMN (reg) --- src/frontend/A32/decoder/thumb32.inc | 2 +- .../thumb32_data_processing_shifted_register.cpp | 15 +++++++++++++++ src/frontend/A32/translate/impl/translate_thumb.h | 1 + 3 files changed, 17 insertions(+), 1 deletion(-) diff --git a/src/frontend/A32/decoder/thumb32.inc b/src/frontend/A32/decoder/thumb32.inc index 9083b48a..62fe7bc4 100644 --- a/src/frontend/A32/decoder/thumb32.inc +++ b/src/frontend/A32/decoder/thumb32.inc @@ -39,7 +39,7 @@ INST(thumb32_ORN_reg, "ORN (reg)", "11101010011Snnnn0vvvdd INST(thumb32_TEQ_reg, "TEQ (reg)", "111010101001nnnn0vvv1111vvttmmmm") INST(thumb32_EOR_reg, "EOR (reg)", "11101010100Snnnn0vvvddddvvttmmmm") INST(thumb32_PKH, "PKH", "111010101100nnnn0vvvddddvvt0mmmm") -//INST(thumb32_CMN_reg, "CMN (reg)", "111010110001--------1111--------") +INST(thumb32_CMN_reg, "CMN (reg)", "111010110001nnnn0vvv1111vvttmmmm") //INST(thumb32_ADD_reg, "ADD (reg)", "11101011000---------------------") //INST(thumb32_ADC_reg, "ADC (reg)", "11101011010---------------------") //INST(thumb32_SBC_reg, "SBC (reg)", "11101011011---------------------") diff --git a/src/frontend/A32/translate/impl/thumb32_data_processing_shifted_register.cpp b/src/frontend/A32/translate/impl/thumb32_data_processing_shifted_register.cpp index 6992d608..2156e17e 100644 --- a/src/frontend/A32/translate/impl/thumb32_data_processing_shifted_register.cpp +++ b/src/frontend/A32/translate/impl/thumb32_data_processing_shifted_register.cpp @@ -170,4 +170,19 @@ bool ThumbTranslatorVisitor::thumb32_PKH(Reg n, Imm<3> imm3, Reg d, Imm<2> imm2, return true; } +bool ThumbTranslatorVisitor::thumb32_CMN_reg(Reg n, Imm<3> imm3, Imm<2> imm2, ShiftType type, Reg m) { + if (n == Reg::PC || m == Reg::PC) { + return UnpredictableInstruction(); + } + + const auto shifted = EmitImmShift(ir.GetRegister(m), type, imm3, imm2, ir.GetCFlag()); + const auto result = ir.AddWithCarry(ir.GetRegister(n), shifted.result, ir.Imm1(0)); + + ir.SetNFlag(ir.MostSignificantBit(result.result)); + ir.SetZFlag(ir.IsZero(result.result)); + ir.SetCFlag(result.carry); + ir.SetVFlag(result.overflow); + return true; +} + } // namespace Dynarmic::A32 diff --git a/src/frontend/A32/translate/impl/translate_thumb.h b/src/frontend/A32/translate/impl/translate_thumb.h index afce0701..b6ff5749 100644 --- a/src/frontend/A32/translate/impl/translate_thumb.h +++ b/src/frontend/A32/translate/impl/translate_thumb.h @@ -182,6 +182,7 @@ struct ThumbTranslatorVisitor final { bool thumb32_TEQ_reg(Reg n, Imm<3> imm3, Imm<2> imm2, ShiftType type, Reg m); bool thumb32_EOR_reg(bool S, Reg n, Imm<3> imm3, Reg d, Imm<2> imm2, ShiftType type, Reg m); bool thumb32_PKH(Reg n, Imm<3> imm3, Reg d, Imm<2> imm2, Imm<1> tb, Reg m); + bool thumb32_CMN_reg(Reg n, Imm<3> imm3, Imm<2> imm2, ShiftType type, Reg m); // thumb32 data processing (modified immediate) instructions bool thumb32_TST_imm(Imm<1> i, Reg n, Imm<3> imm3, Imm<8> imm8);