From de31caca49487bf247e2d1b981c3dcaa70ac29ab Mon Sep 17 00:00:00 2001 From: Merry Date: Fri, 28 May 2021 14:53:21 +0100 Subject: [PATCH] emit_x64_vector_saturation: AVX implementation of EmitVectorUnsignedSaturatedSub32 --- .../x64/emit_x64_vector_saturation.cpp | 44 ++++++++++--------- 1 file changed, 24 insertions(+), 20 deletions(-) diff --git a/src/dynarmic/backend/x64/emit_x64_vector_saturation.cpp b/src/dynarmic/backend/x64/emit_x64_vector_saturation.cpp index 89afff05..45b8f036 100644 --- a/src/dynarmic/backend/x64/emit_x64_vector_saturation.cpp +++ b/src/dynarmic/backend/x64/emit_x64_vector_saturation.cpp @@ -407,38 +407,42 @@ void EmitX64::EmitVectorUnsignedSaturatedSub32(EmitContext& ctx, IR::Inst* inst) void EmitX64::EmitVectorUnsignedSaturatedSub64(EmitContext& ctx, IR::Inst* inst) { auto args = ctx.reg_alloc.GetArgumentInfo(inst); - const Xbyak::Xmm result = ctx.reg_alloc.UseScratchXmm(args[0]); - const Xbyak::Xmm subtrahend = ctx.reg_alloc.UseXmm(args[1]); - const Xbyak::Xmm tmp = ctx.reg_alloc.ScratchXmm(); - const Xbyak::Reg8 overflow = ctx.reg_alloc.ScratchGpr().cvt8(); - - code.movaps(tmp, result); - - // TODO AVX2 if (code.HasHostFeature(HostFeature::AVX512_Ortho | HostFeature::AVX512DQ)) { - // Do a regular unsigned subtraction - code.vpsubq(result, result, subtrahend); + const Xbyak::Xmm operand1 = ctx.reg_alloc.UseXmm(args[0]); + const Xbyak::Xmm operand2 = ctx.reg_alloc.UseXmm(args[1]); + const Xbyak::Xmm result = ctx.reg_alloc.ScratchXmm(); + const Xbyak::Reg8 overflow = ctx.reg_alloc.ScratchGpr().cvt8(); - // Test if an underflow happened - code.vpcmpuq(k1, result, tmp, CmpInt::GreaterThan); - - // Write 0 where underflows have happened + code.vpsubq(result, operand1, operand2); + code.vpcmpuq(k1, result, operand1, CmpInt::GreaterThan); code.vpxorq(result | k1, result, result); - - // Set ZF if an underflow happened code.ktestb(k1, k1); code.setnz(overflow); code.or_(code.byte[code.r15 + code.GetJitStateInfo().offsetof_fpsr_qc], overflow); + ctx.reg_alloc.DefineValue(inst, result); return; } - code.movaps(xmm0, subtrahend); + const Xbyak::Xmm operand1 = code.HasHostFeature(HostFeature::AVX) ? ctx.reg_alloc.UseXmm(args[0]) : ctx.reg_alloc.UseScratchXmm(args[0]); + const Xbyak::Xmm operand2 = ctx.reg_alloc.UseXmm(args[1]); + const Xbyak::Xmm result = code.HasHostFeature(HostFeature::AVX) ? ctx.reg_alloc.ScratchXmm() : operand1; + const Xbyak::Xmm tmp = ctx.reg_alloc.ScratchXmm(); + const Xbyak::Reg8 overflow = ctx.reg_alloc.ScratchGpr().cvt8(); - code.pxor(tmp, subtrahend); - code.psubq(result, subtrahend); - code.pand(xmm0, tmp); + if (code.HasHostFeature(HostFeature::AVX)) { + code.vpxor(tmp, operand1, operand2); + code.vpsubq(result, operand1, operand2); + code.vpand(xmm0, operand2, tmp); + } else { + code.movaps(tmp, operand1); + code.movaps(xmm0, operand2); + + code.pxor(tmp, operand2); + code.psubq(result, operand2); + code.pand(xmm0, tmp); + } code.psrlq(tmp, 1); code.psubq(tmp, xmm0);