/* This file is part of the dynarmic project. * Copyright (c) 2016 MerryMage * SPDX-License-Identifier: 0BSD */ #include #include #include #include #include #include #include #include #include #include #include "common/bit_util.h" #include "common/common_types.h" #include "frontend/A32/disassembler/disassembler.h" #include "frontend/A32/FPSCR.h" #include "frontend/A32/location_descriptor.h" #include "frontend/A32/PSR.h" #include "frontend/A32/translate/translate.h" #include "ir/basic_block.h" #include "ir/opt/passes.h" #include "rand_int.h" #include "testenv.h" #include "unicorn_emu/a32_unicorn.h" using namespace Dynarmic; static A32::UserConfig GetUserConfig(ThumbTestEnv* testenv) { A32::UserConfig user_config; user_config.optimizations &= ~OptimizationFlag::FastDispatch; user_config.callbacks = testenv; return user_config; } using WriteRecords = std::map; struct ThumbInstGen final { public: ThumbInstGen(std::string_view format, std::function is_valid = [](u32){ return true; }) : is_valid(is_valid) { REQUIRE((format.size() == 16 || format.size() == 32)); const auto bit_size = format.size(); for (size_t i = 0; i < bit_size; i++) { const u32 bit = 1U << (bit_size - 1 - i); switch (format[i]) { case '0': mask |= bit; break; case '1': bits |= bit; mask |= bit; break; default: // Do nothing break; } } } u16 Generate16() const { u32 inst; do { const auto random = RandInt(0, 0xFFFF); inst = bits | (random & ~mask); } while (!is_valid(inst)); ASSERT((inst & mask) == bits); return static_cast(inst); } u32 Generate32() const { u32 inst; do { const auto random = RandInt(0, 0xFFFFFFFF); inst = bits | (random & ~mask); } while (!is_valid(inst)); ASSERT((inst & mask) == bits); return inst; } private: u32 bits = 0; u32 mask = 0; std::function is_valid; }; static bool DoesBehaviorMatch(const A32Unicorn& uni, const A32::Jit& jit, const WriteRecords& interp_write_records, const WriteRecords& jit_write_records) { const auto interp_regs = uni.GetRegisters(); const auto jit_regs = jit.Regs(); return std::equal(interp_regs.begin(), interp_regs.end(), jit_regs.begin(), jit_regs.end()) && uni.GetCpsr() == jit.Cpsr() && interp_write_records == jit_write_records; } static void RunInstance(size_t run_number, ThumbTestEnv& test_env, A32Unicorn& uni, A32::Jit& jit, const ThumbTestEnv::RegisterArray& initial_regs, size_t instruction_count, size_t instructions_to_execute_count) { uni.ClearPageCache(); jit.ClearCache(); // Setup initial state uni.SetCpsr(0x000001F0); uni.SetRegisters(initial_regs); jit.SetCpsr(0x000001F0); jit.Regs() = initial_regs; // Run interpreter test_env.modified_memory.clear(); test_env.ticks_left = instructions_to_execute_count; uni.SetPC(uni.GetPC() | 1); uni.Run(); const bool uni_code_memory_modified = test_env.code_mem_modified_by_guest; const auto interp_write_records = test_env.modified_memory; // Run jit test_env.code_mem_modified_by_guest = false; test_env.modified_memory.clear(); test_env.ticks_left = instructions_to_execute_count; jit.Run(); const bool jit_code_memory_modified = test_env.code_mem_modified_by_guest; const auto jit_write_records = test_env.modified_memory; test_env.code_mem_modified_by_guest = false; REQUIRE(uni_code_memory_modified == jit_code_memory_modified); if (uni_code_memory_modified) { return; } // Compare if (!DoesBehaviorMatch(uni, jit, interp_write_records, jit_write_records)) { printf("Failed at execution number %zu\n", run_number); printf("\nInstruction Listing: \n"); for (size_t i = 0; i < instruction_count; i++) { printf("%04x %s\n", test_env.code_mem[i], A32::DisassembleThumb16(test_env.code_mem[i]).c_str()); } printf("\nInitial Register Listing: \n"); for (size_t i = 0; i < initial_regs.size(); i++) { printf("%4zu: %08x\n", i, initial_regs[i]); } printf("\nFinal Register Listing: \n"); printf(" unicorn jit\n"); const auto uni_registers = uni.GetRegisters(); for (size_t i = 0; i < uni_registers.size(); i++) { printf("%4zu: %08x %08x %s\n", i, uni_registers[i], jit.Regs()[i], uni_registers[i] != jit.Regs()[i] ? "*" : ""); } printf("CPSR: %08x %08x %s\n", uni.GetCpsr(), jit.Cpsr(), uni.GetCpsr() != jit.Cpsr() ? "*" : ""); printf("\nUnicorn Write Records:\n"); for (const auto& record : interp_write_records) { printf("[%08x] = %02x\n", record.first, record.second); } printf("\nJIT Write Records:\n"); for (const auto& record : jit_write_records) { printf("[%08x] = %02x\n", record.first, record.second); } A32::PSR cpsr; cpsr.T(true); size_t num_insts = 0; while (num_insts < instructions_to_execute_count) { A32::LocationDescriptor descriptor = {u32(num_insts * 4), cpsr, A32::FPSCR{}}; IR::Block ir_block = A32::Translate(descriptor, [&test_env](u32 vaddr) { return test_env.MemoryReadCode(vaddr); }, {}); Optimization::A32GetSetElimination(ir_block); Optimization::DeadCodeElimination(ir_block); Optimization::A32ConstantMemoryReads(ir_block, &test_env); Optimization::ConstantPropagation(ir_block); Optimization::DeadCodeElimination(ir_block); Optimization::VerificationPass(ir_block); printf("\n\nIR:\n%s", IR::DumpBlock(ir_block).c_str()); printf("\n\nx86_64:\n%s", jit.Disassemble().c_str()); num_insts += ir_block.CycleCount(); } #ifdef _MSC_VER __debugbreak(); #endif FAIL(); } } void FuzzJitThumb16(const size_t instruction_count, const size_t instructions_to_execute_count, const size_t run_count, const std::function instruction_generator) { ThumbTestEnv test_env; // Prepare memory. test_env.code_mem.resize(instruction_count + 1); test_env.code_mem.back() = 0xE7FE; // b +#0 // Prepare test subjects A32Unicorn uni{test_env}; A32::Jit jit{GetUserConfig(&test_env)}; for (size_t run_number = 0; run_number < run_count; run_number++) { ThumbTestEnv::RegisterArray initial_regs; std::generate_n(initial_regs.begin(), initial_regs.size() - 1, []{ return RandInt(0, 0xFFFFFFFF); }); initial_regs[15] = 0; std::generate_n(test_env.code_mem.begin(), instruction_count, instruction_generator); RunInstance(run_number, test_env, uni, jit, initial_regs, instruction_count, instructions_to_execute_count); } } void FuzzJitThumb32(const size_t instruction_count, const size_t instructions_to_execute_count, const size_t run_count, const std::function instruction_generator) { ThumbTestEnv test_env; // Prepare memory. // A Thumb-32 instruction is 32-bits so we multiply our count test_env.code_mem.resize(instruction_count * 2 + 1); test_env.code_mem.back() = 0xE7FE; // b +#0 // Prepare test subjects A32Unicorn uni{test_env}; A32::Jit jit{GetUserConfig(&test_env)}; for (size_t run_number = 0; run_number < run_count; run_number++) { ThumbTestEnv::RegisterArray initial_regs; std::generate_n(initial_regs.begin(), initial_regs.size() - 1, []{ return RandInt(0, 0xFFFFFFFF); }); initial_regs[15] = 0; for (size_t i = 0; i < instruction_count; i++) { const auto instruction = instruction_generator(); const auto first_halfword = static_cast(Common::Bits<0, 15>(instruction)); const auto second_halfword = static_cast(Common::Bits<16, 31>(instruction)); test_env.code_mem[i * 2 + 0] = second_halfword; test_env.code_mem[i * 2 + 1] = first_halfword; } RunInstance(run_number, test_env, uni, jit, initial_regs, instruction_count, instructions_to_execute_count); } } TEST_CASE("Fuzz Thumb instructions set 1", "[JitX64][Thumb][Thumb16]") { const std::array instructions = { ThumbInstGen("00000xxxxxxxxxxx"), // LSL , , # ThumbInstGen("00001xxxxxxxxxxx"), // LSR , , # ThumbInstGen("00010xxxxxxxxxxx"), // ASR , , # ThumbInstGen("000110oxxxxxxxxx"), // ADD/SUB_reg ThumbInstGen("000111oxxxxxxxxx"), // ADD/SUB_imm ThumbInstGen("001ooxxxxxxxxxxx"), // ADD/SUB/CMP/MOV_imm ThumbInstGen("010000ooooxxxxxx"), // Data Processing ThumbInstGen("010001000hxxxxxx"), // ADD (high registers) ThumbInstGen("0100010101xxxxxx", // CMP (high registers) [](u32 inst){ return Common::Bits<3, 5>(inst) != 0b111; }), // R15 is UNPREDICTABLE ThumbInstGen("0100010110xxxxxx", // CMP (high registers) [](u32 inst){ return Common::Bits<0, 2>(inst) != 0b111; }), // R15 is UNPREDICTABLE ThumbInstGen("010001100hxxxxxx"), // MOV (high registers) ThumbInstGen("10110000oxxxxxxx"), // Adjust stack pointer ThumbInstGen("10110010ooxxxxxx"), // SXT/UXT ThumbInstGen("1011101000xxxxxx"), // REV ThumbInstGen("1011101001xxxxxx"), // REV16 ThumbInstGen("1011101011xxxxxx"), // REVSH ThumbInstGen("01001xxxxxxxxxxx"), // LDR Rd, [PC, #] ThumbInstGen("0101oooxxxxxxxxx"), // LDR/STR Rd, [Rn, Rm] ThumbInstGen("011xxxxxxxxxxxxx"), // LDR(B)/STR(B) Rd, [Rn, #] ThumbInstGen("1000xxxxxxxxxxxx"), // LDRH/STRH Rd, [Rn, #offset] ThumbInstGen("1001xxxxxxxxxxxx"), // LDR/STR Rd, [SP, #] ThumbInstGen("1011010xxxxxxxxx", // PUSH [](u32 inst){ return Common::Bits<0, 7>(inst) != 0; }), // Empty reg_list is UNPREDICTABLE ThumbInstGen("10111100xxxxxxxx", // POP (P = 0) [](u32 inst){ return Common::Bits<0, 7>(inst) != 0; }), // Empty reg_list is UNPREDICTABLE ThumbInstGen("1100xxxxxxxxxxxx", // STMIA/LDMIA [](u32 inst) { // Ensure that the architecturally undefined case of // the base register being within the list isn't hit. const u32 rn = Common::Bits<8, 10>(inst); return (inst & (1U << rn)) == 0 && Common::Bits<0, 7>(inst) != 0; }), // TODO: We should properly test against swapped // endianness cases, however Unicorn doesn't // expose the intended endianness of a load/store // operation to memory through its hooks. #if 0 ThumbInstGen("101101100101x000"), // SETEND #endif }; const auto instruction_select = [&]() -> u16 { const auto inst_index = RandInt(0, instructions.size() - 1); return instructions[inst_index].Generate16(); }; SECTION("single instructions") { FuzzJitThumb16(1, 2, 10000, instruction_select); } SECTION("short blocks") { FuzzJitThumb16(5, 6, 3000, instruction_select); } // TODO: Test longer blocks when Unicorn can consistently // run these without going into an infinite loop. #if 0 SECTION("long blocks") { FuzzJitThumb16(1024, 1025, 1000, instruction_select); } #endif } TEST_CASE("Fuzz Thumb instructions set 2 (affects PC)", "[JitX64][Thumb][Thumb16]") { const std::array instructions = { // TODO: We currently can't test BX/BLX as we have // no way of preventing the unpredictable // condition from occurring with the current interface. // (bits zero and one within the specified register // must not be address<1:0> == '10'. #if 0 ThumbInstGen("01000111xmmmm000", // BLX/BX [](u32 inst){ const u32 Rm = Common::Bits<3, 6>(inst); return Rm != 15; }), #endif ThumbInstGen("1010oxxxxxxxxxxx"), // add to pc/sp ThumbInstGen("11100xxxxxxxxxxx"), // B ThumbInstGen("01000100h0xxxxxx"), // ADD (high registers) ThumbInstGen("01000110h0xxxxxx"), // MOV (high registers) ThumbInstGen("1101ccccxxxxxxxx", // B [](u32 inst){ const u32 c = Common::Bits<9, 12>(inst); return c < 0b1110; // Don't want SWI or undefined instructions. }), ThumbInstGen("1011o0i1iiiiinnn"), // CBZ/CBNZ ThumbInstGen("10110110011x0xxx"), // CPS // TODO: We currently have no control over the generated // values when creating new pages, so we can't // reliably test this yet. #if 0 ThumbInstGen("10111101xxxxxxxx"), // POP (R = 1) #endif }; const auto instruction_select = [&]() -> u16 { const auto inst_index = RandInt(0, instructions.size() - 1); return instructions[inst_index].Generate16(); }; FuzzJitThumb16(1, 1, 10000, instruction_select); } TEST_CASE("Fuzz Thumb32 instructions set", "[JitX64][Thumb][Thumb32]") { const auto three_reg_not_r15 = [](u32 inst) { const auto d = Common::Bits<8, 11>(inst); const auto m = Common::Bits<0, 3>(inst); const auto n = Common::Bits<16, 19>(inst); return d != 15 && m != 15 && n != 15; }; const std::array instructions = { ThumbInstGen("111110101011nnnn1111dddd1000mmmm", // CLZ [](u32 inst) { const auto d = Common::Bits<8, 11>(inst); const auto m = Common::Bits<0, 3>(inst); const auto n = Common::Bits<16, 19>(inst); return m == n && d != 15 && m != 15; }), ThumbInstGen("111110101000nnnn1111dddd1000mmmm", // QADD three_reg_not_r15), ThumbInstGen("111110101000nnnn1111dddd0001mmmm", // QADD8 three_reg_not_r15), ThumbInstGen("111110101001nnnn1111dddd0001mmmm", // QADD16 three_reg_not_r15), ThumbInstGen("111110101010nnnn1111dddd0001mmmm", // QASX three_reg_not_r15), ThumbInstGen("111110101000nnnn1111dddd1001mmmm", // QDADD three_reg_not_r15), ThumbInstGen("111110101000nnnn1111dddd1011mmmm", // QDSUB three_reg_not_r15), ThumbInstGen("111110101110nnnn1111dddd0001mmmm", // QSAX three_reg_not_r15), ThumbInstGen("111110101000nnnn1111dddd1010mmmm", // QSUB three_reg_not_r15), ThumbInstGen("111110101100nnnn1111dddd0001mmmm", // QSUB8 three_reg_not_r15), ThumbInstGen("111110101101nnnn1111dddd0001mmmm", // QSUB16 three_reg_not_r15), ThumbInstGen("111110101001nnnn1111dddd1010mmmm", // RBIT [](u32 inst) { const auto d = Common::Bits<8, 11>(inst); const auto m = Common::Bits<0, 3>(inst); const auto n = Common::Bits<16, 19>(inst); return m == n && d != 15 && m != 15; }), ThumbInstGen("111110101001nnnn1111dddd1000mmmm", // REV [](u32 inst) { const auto d = Common::Bits<8, 11>(inst); const auto m = Common::Bits<0, 3>(inst); const auto n = Common::Bits<16, 19>(inst); return m == n && d != 15 && m != 15; }), ThumbInstGen("111110101001nnnn1111dddd1001mmmm", // REV16 [](u32 inst) { const auto d = Common::Bits<8, 11>(inst); const auto m = Common::Bits<0, 3>(inst); const auto n = Common::Bits<16, 19>(inst); return m == n && d != 15 && m != 15; }), ThumbInstGen("111110101001nnnn1111dddd1011mmmm", // REVSH [](u32 inst) { const auto d = Common::Bits<8, 11>(inst); const auto m = Common::Bits<0, 3>(inst); const auto n = Common::Bits<16, 19>(inst); return m == n && d != 15 && m != 15; }), ThumbInstGen("111110101000nnnn1111dddd0000mmmm", // SADD8 three_reg_not_r15), ThumbInstGen("111110101001nnnn1111dddd0000mmmm", // SADD16 three_reg_not_r15), ThumbInstGen("111110101010nnnn1111dddd0000mmmm", // SASX three_reg_not_r15), ThumbInstGen("111110101010nnnn1111dddd1000mmmm", // SEL three_reg_not_r15), ThumbInstGen("111110101000nnnn1111dddd0010mmmm", // SHADD8 three_reg_not_r15), ThumbInstGen("111110101001nnnn1111dddd0010mmmm", // SHADD16 three_reg_not_r15), ThumbInstGen("111110101010nnnn1111dddd0010mmmm", // SHASX three_reg_not_r15), ThumbInstGen("111110101110nnnn1111dddd0010mmmm", // SHSAX three_reg_not_r15), ThumbInstGen("111110101100nnnn1111dddd0010mmmm", // SHSUB8 three_reg_not_r15), ThumbInstGen("111110101101nnnn1111dddd0010mmmm", // SHSUB16 three_reg_not_r15), ThumbInstGen("111110101110nnnn1111dddd0000mmmm", // SSAX three_reg_not_r15), ThumbInstGen("111110101100nnnn1111dddd0000mmmm", // SSUB8 three_reg_not_r15), ThumbInstGen("111110101101nnnn1111dddd0000mmmm", // SSUB16 three_reg_not_r15), ThumbInstGen("111110101000nnnn1111dddd0100mmmm", // UADD8 three_reg_not_r15), ThumbInstGen("111110101001nnnn1111dddd0100mmmm", // UADD16 three_reg_not_r15), ThumbInstGen("111110101010nnnn1111dddd0100mmmm", // UASX three_reg_not_r15), ThumbInstGen("111110101000nnnn1111dddd0110mmmm", // UHADD8 three_reg_not_r15), ThumbInstGen("111110101001nnnn1111dddd0110mmmm", // UHADD16 three_reg_not_r15), ThumbInstGen("111110101010nnnn1111dddd0110mmmm", // UHASX three_reg_not_r15), ThumbInstGen("111110101110nnnn1111dddd0110mmmm", // UHSAX three_reg_not_r15), ThumbInstGen("111110101100nnnn1111dddd0110mmmm", // UHSUB8 three_reg_not_r15), ThumbInstGen("111110101101nnnn1111dddd0110mmmm", // UHSUB16 three_reg_not_r15), ThumbInstGen("111110101000nnnn1111dddd0101mmmm", // UQADD8 three_reg_not_r15), ThumbInstGen("111110101001nnnn1111dddd0101mmmm", // UQADD16 three_reg_not_r15), ThumbInstGen("111110101010nnnn1111dddd0101mmmm", // UQASX three_reg_not_r15), ThumbInstGen("111110101110nnnn1111dddd0101mmmm", // UQSAX three_reg_not_r15), ThumbInstGen("111110101100nnnn1111dddd0101mmmm", // UQSUB8 three_reg_not_r15), ThumbInstGen("111110101101nnnn1111dddd0101mmmm", // UQSUB16 three_reg_not_r15), ThumbInstGen("111110101110nnnn1111dddd0100mmmm", // USAX three_reg_not_r15), ThumbInstGen("111110101100nnnn1111dddd0100mmmm", // USUB8 three_reg_not_r15), ThumbInstGen("111110101101nnnn1111dddd0100mmmm", // USUB16 three_reg_not_r15), }; const auto instruction_select = [&]() -> u32 { const auto inst_index = RandInt(0, instructions.size() - 1); return instructions[inst_index].Generate32(); }; SECTION("single instructions") { FuzzJitThumb32(1, 2, 10000, instruction_select); } SECTION("short blocks") { FuzzJitThumb32(5, 6, 3000, instruction_select); } } TEST_CASE("Verify fix for off by one error in MemoryRead32 worked", "[Thumb][Thumb16]") { ThumbTestEnv test_env; // Prepare test subjects A32Unicorn uni{test_env}; A32::Jit jit{GetUserConfig(&test_env)}; constexpr ThumbTestEnv::RegisterArray initial_regs { 0xe90ecd70, 0x3e3b73c3, 0x571616f9, 0x0b1ef45a, 0xb3a829f2, 0x915a7a6a, 0x579c38f4, 0xd9ffe391, 0x55b6682b, 0x458d8f37, 0x8f3eb3dc, 0xe18c0e7d, 0x6752657a, 0x00001766, 0xdbbf23e3, 0x00000000, }; test_env.code_mem = { 0x40B8, // lsls r0, r7, #0 0x01CA, // lsls r2, r1, #7 0x83A1, // strh r1, [r4, #28] 0x708A, // strb r2, [r1, #2] 0xBCC4, // pop {r2, r6, r7} 0xE7FE, // b +#0 }; RunInstance(1, test_env, uni, jit, initial_regs, 5, 5); }