citra/src/common
Tobias 623b0621ab
Port various minor changes from yuzu PRs (#4725)
* common/thread: Remove unused functions

Many of these functions are carried over from Dolphin (where they aren't
used anymore). Given these have no use (and we really shouldn't be
screwing around with OS-specific thread scheduler handling from the
emulator, these can be removed.

The function for setting the thread name is left, however, since it can
have debugging utility usages.

* input_common/sdl: Use a type alias to shorten declaration of GetPollers

Just makes the definitions a little bit more tidy.

* input_common/sdl: Correct return values within implementations of GetPollers()

In both cases, we weren't actually returning anything, which is
undefined behavior.

* yuzu/debugger/graphics_surface: Fill in missing surface format listings

Fills in the missing surface types that were marked as unknown. The
order corresponds with the TextureFormat enum within
video_core/texture.h.

We also don't need to all of these strings as translatable (only the
first string, as it's an English word).

* yuzu/debugger/graphics_surface: Clean up connection overload deduction

We can utilize qOverload with the signal connections to make the
function deducing a little less ugly.

* yuzu/debugger/graphics_surface: Tidy up SaveSurface

- Use QStringLiteral where applicable.

- Use const where applicable

- Remove unnecessary precondition check (we already assert the pixbuf
  being non null)

* yuzu/debugger/graphics_surface: Display error messages for file I/O errors

* core: Add missing override specifiers where applicable

Applies the override specifier where applicable. In the case of
destructors that are  defaulted in their definition, they can
simply be removed.

This also removes the unnecessary inclusions being done in audin_u and
audrec_u, given their close proximity.

* kernel/thread: Make parameter of GetWaitObjectIndex() const qualified

The pointed to member is never actually modified, so it can be made
const.

* kernel/thread: Avoid sign conversion within GetCommandBufferAddress()

Previously this was performing a u64 + int sign conversion. When dealing
with addresses, we should generally be keeping the arithmetic in the
same signedness type.

This also gets rid of the static lifetime of the constant, as there's no
need to make a trivial type like this potentially live for the entire
duration of the program.

* kernel/codeset: Make CodeSet's memory data member a regular std::vector

The use of a shared_ptr is an implementation detail of the VMManager
itself when mapping memory. Because of that, we shouldn't require all
users of the CodeSet to have to allocate the shared_ptr ahead of time.
It's intended that CodeSet simply pass in the required direct data, and
that the memory manager takes care of it from that point on.

This means we just do the shared pointer allocation in a single place,
when loading modules, as opposed to in each loader.

* kernel/wait_object: Make ShouldWait() take thread members by pointer-to-const

Given this is intended as a querying function, it doesn't make sense to
allow the implementer to modify the state of the given thread.
2019-05-01 14:28:49 +02:00
..
logging Merge pull request #4733 from zhaowenlan1779/ps 2019-04-29 21:39:53 +08:00
x64 Prefix all size_t with std:: 2018-09-06 16:03:28 -04:00
alignment.h Prefix all size_t with std:: 2018-09-06 16:03:28 -04:00
announce_multiplayer_room.h core, web_service: Check for error when registering rooms 2019-04-20 12:50:14 +08:00
assert.h reformat all files with clang-format 2018-06-29 16:56:12 +03:00
bit_field.h common/bit_field: Make BitField trivially copyable 2019-03-16 04:10:03 +01:00
bit_set.h Prefix all size_t with std:: 2018-09-06 16:03:28 -04:00
chunk_file.h reformat all files with clang-format 2018-06-29 16:56:12 +03:00
cityhash.cpp Prefix all size_t with std:: 2018-09-06 16:03:28 -04:00
cityhash.h Prefix all size_t with std:: 2018-09-06 16:03:28 -04:00
CMakeLists.txt common/thread_queue_list: Remove unnecessary dependency on boost 2019-03-22 23:13:30 +01:00
color.h common/vector_math: Move Vec[x] types into the Common namespace 2019-03-02 15:04:13 +01:00
common_funcs.h Merge pull request #4021 from FearlessTobi/port-709 2018-08-02 11:00:53 -06:00
common_paths.h FFmpegDL: Added external_dlls folder to user folder 2019-02-09 11:52:31 +01:00
common_types.h Sources: Run clang-format on everything. 2016-09-18 09:38:01 +09:00
detached_tasks.cpp general: Use deducation guides for std::lock_guard and std::unique_lock 2019-04-07 15:14:29 +02:00
detached_tasks.h Review comments - part 5 2018-10-20 10:35:55 -04:00
file_util.cpp appease clang format 2019-03-09 19:15:35 -06:00
file_util.h common: decouple getting and setting user paths 2019-02-15 14:48:31 -06:00
hash.h Prefix all size_t with std:: 2018-09-06 16:03:28 -04:00
linear_disk_cache.h Sources: Run clang-format on everything. 2016-09-18 09:38:01 +09:00
math_util.h common/math_util: Move contents into the Common namespace 2019-03-02 18:13:10 +01:00
microprofile.cpp Integrate the MicroProfile profiling library 2015-08-24 22:16:28 -03:00
microprofile.h Sources: Run clang-format on everything. 2016-09-18 09:38:01 +09:00
microprofileui.h Common: Remove section measurement from profiler (#1731) 2016-04-29 00:07:10 -07:00
misc.cpp Prefix all size_t with std:: 2018-09-06 16:03:28 -04:00
param_package.cpp citra_qt/configuration: misc input tab improvements 2018-09-08 11:26:10 +08:00
param_package.h citra_qt/configuration: misc input tab improvements 2018-09-08 11:26:10 +08:00
quaternion.h common/vector_math: Move Vec[x] types into the Common namespace 2019-03-02 15:04:13 +01:00
ring_buffer.h ring_buffer: Fix Push 2018-09-19 07:14:36 +01:00
scm_rev.cpp.in common: Parse Nightly/Canary build version 2018-06-20 09:30:26 +08:00
scm_rev.h common: Parse Nightly/Canary build version 2018-06-20 09:30:26 +08:00
scope_exit.h common/scope_exit: Replace std::move with std::forward in ScopeExit() 2019-04-15 17:55:44 +02:00
string_util.cpp remove Common::TrimSourcePath 2019-03-10 19:18:09 -05:00
string_util.h common/string_util: Move TextFromBuffer to string_util 2019-04-08 22:34:21 +08:00
swap.h common/swap: Improve codegen of the default swap fallbacks 2019-04-15 17:56:16 +02:00
telemetry.cpp common: Add a generic interface for logging telemetry fields. 2017-05-24 19:16:21 -04:00
telemetry.h compatdb: Use a seperate endpoint for testcase submission 2018-10-27 12:20:03 +02:00
thread.cpp Port various minor changes from yuzu PRs (#4725) 2019-05-01 14:28:49 +02:00
thread.h Port various minor changes from yuzu PRs (#4725) 2019-05-01 14:28:49 +02:00
thread_queue_list.h common/thread_queue_list: Remove unnecessary dependency on boost 2019-03-22 23:13:30 +01:00
threadsafe_queue.h general: Use deducation guides for std::lock_guard and std::unique_lock 2019-04-07 15:14:29 +02:00
timer.cpp Address review comments 2018-09-06 00:00:21 +02:00
timer.h common/timer: use std::chrono, avoid platform-dependent code 2018-07-22 15:40:07 +08:00
vector_math.h common/vector_math: Move Vec[x] types into the Common namespace 2019-03-02 15:04:13 +01:00
web_result.h Put WebResult into a seperate file 2018-10-27 00:39:02 +02:00