mirrors/dynarmic
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

emit_x64: Remove FPSCR_RoundTowardsZero() virtual function from EmitContext struct

Browse source 
This code was bugged in that we were comparing if the rounding mode was
not equal to rounding towards zero. Fortunately, however, nothing uses
this function anymore, and there's already the more general
FPSCR_RMode() available, so this can be removed entirely.
This commit is contained in:
Lioncash 2018-07-17 14:05:54 -04:00 committed by MerryMage
parent fd92e2f186
commit 0ec8dac660
5 changed files with 0 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/backend_x64/a32_emit_x64.cpp
View file

@ -66,10 +66,6 @@ u32 A32EmitContext::FPCR() const {
return Location().FPSCR().Value(); return Location().FPSCR().Value();
} }
bool A32EmitContext::FPSCR_RoundTowardsZero() const {
return Location().FPSCR().RMode() != FP::RoundingMode::TowardsZero;
}
bool A32EmitContext::FPSCR_FTZ() const { bool A32EmitContext::FPSCR_FTZ() const {
return Location().FPSCR().FTZ(); return Location().FPSCR().FTZ();
} }

1
src/backend_x64/a32_emit_x64.h
View file

@ -25,7 +25,6 @@ struct A32EmitContext final : public EmitContext {
A32::LocationDescriptor Location() const; A32::LocationDescriptor Location() const;
FP::RoundingMode FPSCR_RMode() const override; FP::RoundingMode FPSCR_RMode() const override;
u32 FPCR() const override; u32 FPCR() const override;
bool FPSCR_RoundTowardsZero() const override;
bool FPSCR_FTZ() const override; bool FPSCR_FTZ() const override;
bool FPSCR_DN() const override; bool FPSCR_DN() const override;
}; };

4
src/backend_x64/a64_emit_x64.cpp
View file

@ -48,10 +48,6 @@ u32 A64EmitContext::FPCR() const {
return Location().FPCR().Value(); return Location().FPCR().Value();
} }
bool A64EmitContext::FPSCR_RoundTowardsZero() const {
return Location().FPCR().RMode() != FP::RoundingMode::TowardsZero;
}
bool A64EmitContext::FPSCR_FTZ() const { bool A64EmitContext::FPSCR_FTZ() const {
return Location().FPCR().FZ(); return Location().FPCR().FZ();
} }

1
src/backend_x64/a64_emit_x64.h
View file

@ -25,7 +25,6 @@ struct A64EmitContext final : public EmitContext {
A64::LocationDescriptor Location() const; A64::LocationDescriptor Location() const;
FP::RoundingMode FPSCR_RMode() const override; FP::RoundingMode FPSCR_RMode() const override;
u32 FPCR() const override; u32 FPCR() const override;
bool FPSCR_RoundTowardsZero() const override;
bool FPSCR_FTZ() const override; bool FPSCR_FTZ() const override;
bool FPSCR_DN() const override; bool FPSCR_DN() const override;
bool AccurateNaN() const override; bool AccurateNaN() const override;

1
src/backend_x64/emit_x64.h
View file

@ -47,7 +47,6 @@ struct EmitContext {
virtual FP::RoundingMode FPSCR_RMode() const = 0; virtual FP::RoundingMode FPSCR_RMode() const = 0;
virtual u32 FPCR() const = 0; virtual u32 FPCR() const = 0;
virtual bool FPSCR_RoundTowardsZero() const = 0;
virtual bool FPSCR_FTZ() const = 0; virtual bool FPSCR_FTZ() const = 0;
virtual bool FPSCR_DN() const = 0; virtual bool FPSCR_DN() const = 0;
virtual bool AccurateNaN() const { return true; } virtual bool AccurateNaN() const { return true; }