mirrors/dynarmic
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

a32_get_set_elimination_pass: New algorithm

Browse source
This commit is contained in:
Merry 2023-01-19 18:52:41 +00:00
parent 76aa4dd665
commit 33fa44acf6
1 changed files with 120 additions and 107 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

227
src/dynarmic/ir/opt/a32_get_set_elimination_pass.cpp
View file

@ -17,59 +17,58 @@
namespace Dynarmic::Optimization { namespace Dynarmic::Optimization {
void A32GetSetElimination(IR::Block& block, A32GetSetEliminationOptions opt) { void A32GetSetElimination(IR::Block& block, A32GetSetEliminationOptions) {
using Iterator = IR::Block::iterator; using Iterator = std::reverse_iterator<IR::Block::iterator>;
struct RegisterInfo { struct RegisterInfo {
IR::Value register_value; bool set_not_required = false;
bool set_instruction_present = false; bool has_value_request = false;
Iterator last_set_instruction; Iterator value_request = {};
};
struct ValuelessRegisterInfo {
bool set_not_required = false;
}; };
std::array<RegisterInfo, 15> reg_info; std::array<RegisterInfo, 15> reg_info;
std::array<RegisterInfo, 64> ext_reg_singles_info; std::array<RegisterInfo, 64> ext_reg_singles_info;
std::array<RegisterInfo, 32> ext_reg_doubles_info; std::array<RegisterInfo, 32> ext_reg_doubles_info;
std::array<RegisterInfo, 32> ext_reg_vector_double_info; std::array<RegisterInfo, 32> ext_reg_vector_double_info;
std::array<RegisterInfo, 16> ext_reg_vector_quad_info; std::array<RegisterInfo, 16> ext_reg_vector_quad_info;
struct CpsrInfo { ValuelessRegisterInfo nzcvq;
RegisterInfo nz; ValuelessRegisterInfo nzcv;
RegisterInfo c; ValuelessRegisterInfo nz;
RegisterInfo nzc; RegisterInfo c_flag;
RegisterInfo nzcv; RegisterInfo ge;
RegisterInfo ge;
} cpsr_info;
const auto do_delete_last_set = [&block](RegisterInfo& info) { auto do_set = [&](RegisterInfo& info, IR::Value value, Iterator inst) {
if (info.set_instruction_present) { if (info.has_value_request) {
info.set_instruction_present = false; info.value_request->ReplaceUsesWith(value);
info.last_set_instruction->Invalidate();
block.Instructions().erase(info.last_set_instruction);
} }
info = {}; info.has_value_request = false;
};
const auto do_set = [&do_delete_last_set](RegisterInfo& info, IR::Value value, Iterator set_inst) { if (info.set_not_required) {
do_delete_last_set(info); inst->Invalidate();
info.register_value = value;
info.set_instruction_present = true;
info.last_set_instruction = set_inst;
};
const auto do_set_without_inst = [&do_delete_last_set](RegisterInfo& info, IR::Value value) {
do_delete_last_set(info);
info.register_value = value;
};
const auto do_get = [](RegisterInfo& info, Iterator get_inst) {
if (info.register_value.IsEmpty()) {
info.register_value = IR::Value(&*get_inst);
return;
} }
get_inst->ReplaceUsesWith(info.register_value); info.set_not_required = true;
};
auto do_set_valueless = [&](ValuelessRegisterInfo& info, Iterator inst) {
if (info.set_not_required) {
inst->Invalidate();
}
info.set_not_required = true;
};
auto do_get = [](RegisterInfo& info, Iterator inst) {
if (info.has_value_request) {
info.value_request->ReplaceUsesWith(IR::Value{&*inst});
}
info.has_value_request = true;
info.value_request = inst;
}; };
// Location and version don't matter here.
A32::IREmitter ir{block, A32::LocationDescriptor{block.Location()}, {}}; A32::IREmitter ir{block, A32::LocationDescriptor{block.Location()}, {}};
for (auto inst = block.begin(); inst != block.end(); ++inst) { for (auto inst = block.rbegin(); inst != block.rend(); ++inst) {
switch (inst->GetOpcode()) { switch (inst->GetOpcode()) {
case IR::Opcode::A32SetRegister: { case IR::Opcode::A32SetRegister: {
const A32::Reg reg = inst->GetArg(0).GetA32RegRef(); const A32::Reg reg = inst->GetArg(0).GetA32RegRef();
@ -101,10 +100,6 @@ void A32GetSetElimination(IR::Block& block, A32GetSetEliminationOptions opt) {
const A32::ExtReg reg = inst->GetArg(0).GetA32ExtRegRef(); const A32::ExtReg reg = inst->GetArg(0).GetA32ExtRegRef();
const size_t reg_index = A32::RegNumber(reg); const size_t reg_index = A32::RegNumber(reg);
do_get(ext_reg_singles_info[reg_index], inst); do_get(ext_reg_singles_info[reg_index], inst);
ext_reg_doubles_info[reg_index / 2] = {};
ext_reg_vector_double_info[reg_index / 2] = {};
ext_reg_vector_quad_info[reg_index / 4] = {};
break; break;
} }
case IR::Opcode::A32SetExtendedRegister64: { case IR::Opcode::A32SetExtendedRegister64: {
@ -122,11 +117,6 @@ void A32GetSetElimination(IR::Block& block, A32GetSetEliminationOptions opt) {
const A32::ExtReg reg = inst->GetArg(0).GetA32ExtRegRef(); const A32::ExtReg reg = inst->GetArg(0).GetA32ExtRegRef();
const size_t reg_index = A32::RegNumber(reg); const size_t reg_index = A32::RegNumber(reg);
do_get(ext_reg_doubles_info[reg_index], inst); do_get(ext_reg_doubles_info[reg_index], inst);
ext_reg_singles_info[reg_index * 2 + 0] = {};
ext_reg_singles_info[reg_index * 2 + 1] = {};
ext_reg_vector_double_info[reg_index] = {};
ext_reg_vector_quad_info[reg_index / 2] = {};
break; break;
} }
case IR::Opcode::A32SetVector: { case IR::Opcode::A32SetVector: {
@ -160,100 +150,123 @@ void A32GetSetElimination(IR::Block& block, A32GetSetEliminationOptions opt) {
const size_t reg_index = A32::RegNumber(reg); const size_t reg_index = A32::RegNumber(reg);
if (A32::IsDoubleExtReg(reg)) { if (A32::IsDoubleExtReg(reg)) {
do_get(ext_reg_vector_double_info[reg_index], inst); do_get(ext_reg_vector_double_info[reg_index], inst);
ext_reg_singles_info[reg_index * 2 + 0] = {};
ext_reg_singles_info[reg_index * 2 + 1] = {};
ext_reg_doubles_info[reg_index] = {};
ext_reg_vector_quad_info[reg_index / 2] = {};
} else { } else {
DEBUG_ASSERT(A32::IsQuadExtReg(reg)); DEBUG_ASSERT(A32::IsQuadExtReg(reg));
do_get(ext_reg_vector_quad_info[reg_index], inst); do_get(ext_reg_vector_quad_info[reg_index], inst);
ext_reg_singles_info[reg_index * 4 + 0] = {};
ext_reg_singles_info[reg_index * 4 + 1] = {};
ext_reg_singles_info[reg_index * 4 + 2] = {};
ext_reg_singles_info[reg_index * 4 + 3] = {};
ext_reg_doubles_info[reg_index * 2 + 0] = {};
ext_reg_doubles_info[reg_index * 2 + 1] = {};
ext_reg_vector_double_info[reg_index * 2 + 0] = {};
ext_reg_vector_double_info[reg_index * 2 + 1] = {};
} }
break; break;
} }
case IR::Opcode::A32GetCFlag: { case IR::Opcode::A32GetCFlag: {
if (cpsr_info.c.register_value.IsEmpty() && cpsr_info.nzcv.register_value.GetType() == IR::Type::NZCVFlags) { do_get(c_flag, inst);
ir.SetInsertionPointBefore(inst); break;
IR::U1 c = ir.GetCFlagFromNZCV(IR::NZCV{cpsr_info.nzcv.register_value}); }
inst->ReplaceUsesWith(c); case IR::Opcode::A32SetCpsrNZCV: {
cpsr_info.c.register_value = c; if (c_flag.has_value_request) {
break; ir.SetInsertionPointBefore(inst.base()); // base is one ahead
} IR::U1 c = ir.GetCFlagFromNZCV(IR::NZCV{inst->GetArg(0)});
c_flag.value_request->ReplaceUsesWith(c);
do_get(cpsr_info.c, inst); c_flag.has_value_request = false;
// ensure source is not deleted break; // This case will be executed again because of the above
cpsr_info.nzc = {}; }
cpsr_info.nzcv = {};
do_set_valueless(nzcv, inst);
nz = {.set_not_required = true};
c_flag = {.set_not_required = true};
break; break;
} }
case IR::Opcode::A32SetCpsrNZCV:
case IR::Opcode::A32SetCpsrNZCVRaw: { case IR::Opcode::A32SetCpsrNZCVRaw: {
do_delete_last_set(cpsr_info.nz); if (c_flag.has_value_request) {
do_delete_last_set(cpsr_info.c); nzcv.set_not_required = false;
do_delete_last_set(cpsr_info.nzc); }
do_set(cpsr_info.nzcv, inst->GetArg(0), inst);
do_set_valueless(nzcv, inst);
nzcvq = {};
nz = {.set_not_required = true};
c_flag = {.set_not_required = true};
break; break;
} }
case IR::Opcode::A32SetCpsrNZCVQ: { case IR::Opcode::A32SetCpsrNZCVQ: {
do_delete_last_set(cpsr_info.nz); if (c_flag.has_value_request) {
do_delete_last_set(cpsr_info.c); nzcvq.set_not_required = false;
do_delete_last_set(cpsr_info.nzc); }
do_delete_last_set(cpsr_info.nzcv);
do_set_valueless(nzcvq, inst);
nzcv = {.set_not_required = true};
nz = {.set_not_required = true};
c_flag = {.set_not_required = true};
break; break;
} }
case IR::Opcode::A32SetCpsrNZ: { case IR::Opcode::A32SetCpsrNZ: {
if (cpsr_info.nzc.set_instruction_present) { do_set_valueless(nz, inst);
cpsr_info.nzc.last_set_instruction->SetArg(0, IR::Value::EmptyNZCVImmediateMarker());
}
if (opt.convert_nz_to_nzc && !cpsr_info.c.register_value.IsEmpty()) { nzcvq = {};
ir.SetInsertionPointAfter(inst); nzcv = {};
ir.SetCpsrNZC(IR::NZCV{inst->GetArg(0)}, ir.GetCFlag());
inst->Invalidate();
break;
}
// cpsr_info.c remains valid
cpsr_info.nzc = {};
cpsr_info.nzcv = {};
do_set(cpsr_info.nz, inst->GetArg(0), inst);
break; break;
} }
case IR::Opcode::A32SetCpsrNZC: { case IR::Opcode::A32SetCpsrNZC: {
if (opt.convert_nzc_to_nz && !inst->GetArg(1).IsImmediate() && inst->GetArg(1).GetInstRecursive()->GetOpcode() == IR::Opcode::A32GetCFlag) { if (c_flag.has_value_request) {
ir.SetInsertionPointAfter(inst); c_flag.value_request->ReplaceUsesWith(inst->GetArg(1));
ir.SetCpsrNZ(IR::NZCV{inst->GetArg(0)}); c_flag.has_value_request = false;
}
if (!inst->GetArg(1).IsImmediate() && inst->GetArg(1).GetInstRecursive()->GetOpcode() == IR::Opcode::A32GetCFlag) {
const auto nz_value = inst->GetArg(0);
inst->Invalidate(); inst->Invalidate();
ir.SetInsertionPointBefore(inst.base());
ir.SetCpsrNZ(IR::NZCV{nz_value});
nzcvq = {};
nzcv = {};
nz = {.set_not_required = true};
break; break;
} }
cpsr_info.nzcv = {}; if (nz.set_not_required && c_flag.set_not_required) {
do_set(cpsr_info.nzc, {}, inst); inst->Invalidate();
do_set_without_inst(cpsr_info.nz, inst->GetArg(0)); } else if (nz.set_not_required) {
do_set_without_inst(cpsr_info.c, inst->GetArg(1)); inst->SetArg(0, IR::Value::EmptyNZCVImmediateMarker());
}
nz.set_not_required = true;
c_flag.set_not_required = true;
nzcv = {};
nzcvq = {};
break; break;
} }
case IR::Opcode::A32SetGEFlags: { case IR::Opcode::A32SetGEFlags: {
do_set(cpsr_info.ge, inst->GetArg(0), inst); do_set(ge, inst->GetArg(0), inst);
break; break;
} }
case IR::Opcode::A32GetGEFlags: { case IR::Opcode::A32GetGEFlags: {
do_get(cpsr_info.ge, inst); do_get(ge, inst);
break;
}
case IR::Opcode::A32SetGEFlagsCompressed: {
ge = {.set_not_required = true};
break;
}
case IR::Opcode::A32OrQFlag: {
break; break;
} }
default: { default: {
if (inst->ReadsFromCPSR() || inst->WritesToCPSR()) { if (inst->ReadsFromCPSR() || inst->WritesToCPSR()) {
cpsr_info = {}; nzcvq = {};
nzcv = {};
nz = {};
c_flag = {};
ge = {};
}
if (inst->ReadsFromCoreRegister() || inst->WritesToCoreRegister()) {
reg_info = {};
ext_reg_singles_info = {};
ext_reg_doubles_info = {};
ext_reg_vector_double_info = {};
ext_reg_vector_quad_info = {};
} }
break; break;
} }