mirrors/dynarmic
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

decoder_detail: Fix bit_position and one unused warnings in GetArgInfo

Browse source
This commit is contained in:
MerryMage 2020-12-28 23:34:23 +00:00
parent b47e5ea1e1
commit 42059edca4
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/frontend/decoder/decoder_detail.h
View file

@ -63,15 +63,12 @@ private:
*/ */
template<size_t N> template<size_t N>
static auto GetArgInfo(const char* const bitstring) { static auto GetArgInfo(const char* const bitstring) {
const auto one = static_cast<opcode_type>(1);
std::array<opcode_type, N> masks = {}; std::array<opcode_type, N> masks = {};
std::array<size_t, N> shifts = {}; std::array<size_t, N> shifts = {};
size_t arg_index = 0; size_t arg_index = 0;
char ch = 0; char ch = 0;
for (size_t i = 0; i < opcode_bitsize; i++) { for (size_t i = 0; i < opcode_bitsize; i++) {
const size_t bit_position = opcode_bitsize - i - 1;
if (bitstring[i] == '0' || bitstring[i] == '1' || bitstring[i] == '-') { if (bitstring[i] == '0' || bitstring[i] == '1' || bitstring[i] == '-') {
if (ch != 0) { if (ch != 0) {
ch = 0; ch = 0;
@ -86,8 +83,10 @@ private:
} }
if constexpr (N > 0) { if constexpr (N > 0) {
const size_t bit_position = opcode_bitsize - i - 1;
ASSERT(arg_index < N); ASSERT(arg_index < N);
masks[arg_index] |= one << bit_position; masks[arg_index] |= static_cast<opcode_type>(1) << bit_position;
shifts[arg_index] = bit_position; shifts[arg_index] = bit_position;
} else { } else {
ASSERT_FALSE(); ASSERT_FALSE();