mirrors/dynarmic
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

emit_x64_vector: Bugfix for EmitVectorLogicalShiftRight8: shift_amount can be >= 8

Browse source
This commit is contained in:
Merry 2021-03-27 21:32:07 +00:00
parent 91337788ee
commit 4d33feb1fa
1 changed files with 12 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/backend/x64/emit_x64_vector.cpp
View file

@ -1524,9 +1524,11 @@ void EmitX64::EmitVectorLogicalShiftRight8(EmitContext& ctx, IR::Inst* inst) {
const Xbyak::Xmm result = ctx.reg_alloc.UseScratchXmm(args[0]); const Xbyak::Xmm result = ctx.reg_alloc.UseScratchXmm(args[0]);
const u8 shift_amount = args[1].GetImmediateU8(); const u8 shift_amount = args[1].GetImmediateU8();
if (shift_amount > 0) { if (shift_amount == 0) {
if (code.HasAVX512_Icelake()) { // Do nothing
// Galois 8x8 identity matrix, bit-shifted by the shift-amount } else if (shift_amount >= 8) {
code.pxor(result, result);
} else if (code.HasAVX512_Icelake()) {
const u64 shift_matrix = 0x0102040810204080 << (shift_amount * 8); const u64 shift_matrix = 0x0102040810204080 << (shift_amount * 8);
code.vgf2p8affineqb(result, result, code.MConst(xword_b, shift_matrix), 0); code.vgf2p8affineqb(result, result, code.MConst(xword_b, shift_matrix), 0);
} else { } else {
@ -1536,7 +1538,6 @@ void EmitX64::EmitVectorLogicalShiftRight8(EmitContext& ctx, IR::Inst* inst) {
code.psrlw(result, shift_amount); code.psrlw(result, shift_amount);
code.pand(result, code.MConst(xword, mask, mask)); code.pand(result, code.MConst(xword, mask, mask));
} }
}
ctx.reg_alloc.DefineValue(inst, result); ctx.reg_alloc.DefineValue(inst, result);
} }