A64: Implement ISB

Given we want to ensure that all instructions are fetched again, we can
treat an ISB instruction as a code cache flush.

src/backend_x64/a64_emit_x64.cpp

@@ -60,8 +60,8 @@ bool A64EmitContext::AccurateNaN() const {
     return conf.floating_point_nan_accuracy == A64::UserConfig::NaNAccuracy::Accurate;
 }
 
-A64EmitX64::A64EmitX64(BlockOfCode& code, A64::UserConfig conf)
+A64EmitX64::A64EmitX64(BlockOfCode& code, A64::UserConfig conf, A64::Jit* jit_interface)
-    : EmitX64(code), conf(conf)
+    : EmitX64(code), conf(conf), jit_interface{jit_interface}
 {
     GenMemory128Accessors();
     GenFastmemFallbacks();
@@ -538,6 +538,15 @@ void A64EmitX64::EmitA64DataMemoryBarrier(A64EmitContext&, IR::Inst*) {
     code.lfence();
 }
 
+void A64EmitX64::EmitA64InstructionSynchronizationBarrier(A64EmitContext& ctx, IR::Inst* ) {
+    ctx.reg_alloc.HostCall(nullptr);
+
+    code.mov(code.ABI_PARAM1, reinterpret_cast<u64>(jit_interface));
+    code.CallFunction(static_cast<void(*)(A64::Jit*)>([](A64::Jit* jit) {
+        jit->ClearCache();
+    }));
+}
+
 void A64EmitX64::EmitA64GetCNTFRQ(A64EmitContext& ctx, IR::Inst* inst) {
     Xbyak::Reg32 result = ctx.reg_alloc.ScratchGpr().cvt32();
     code.mov(result, conf.cntfrq_el0);

src/backend_x64/a64_emit_x64.h

@@ -12,6 +12,7 @@
 #include "backend_x64/a64_jitstate.h"
 #include "backend_x64/block_range_information.h"
 #include "backend_x64/emit_x64.h"
+#include "dynarmic/A64/a64.h"
 #include "dynarmic/A64/config.h"
 #include "frontend/A64/location_descriptor.h"
 #include "frontend/ir/terminal.h"
@@ -34,7 +35,7 @@ struct A64EmitContext final : public EmitContext {
 
 class A64EmitX64 final : public EmitX64 {
 public:
-    A64EmitX64(BlockOfCode& code, A64::UserConfig conf);
+    A64EmitX64(BlockOfCode& code, A64::UserConfig conf, A64::Jit* jit_interface);
     ~A64EmitX64() override;
 
     /**
@@ -49,6 +50,7 @@ public:
 
 protected:
     const A64::UserConfig conf;
+    A64::Jit* jit_interface;
     BlockRangeInformation<u64> block_ranges;
 
     void (*memory_read_128)();

src/backend_x64/a64_interface.cpp

@@ -36,10 +36,10 @@ static RunCodeCallbacks GenRunCodeCallbacks(A64::UserCallbacks* cb, CodePtr (*Lo
 
 struct Jit::Impl final {
 public:
-    explicit Impl(UserConfig conf)
+    Impl(Jit* jit, UserConfig conf)
         : conf(conf) 
         , block_of_code(GenRunCodeCallbacks(conf.callbacks, &GetCurrentBlockThunk, this), JitStateInfo{jit_state})
-        , emitter(block_of_code, conf)
+        , emitter(block_of_code, conf, jit)
     {
         ASSERT(conf.page_table_address_space_bits >= 12 && conf.page_table_address_space_bits <= 64);
     }
@@ -247,7 +247,7 @@ private:
 };
 
 Jit::Jit(UserConfig conf)
-    : impl(std::make_unique<Jit::Impl>(conf)) {}
+    : impl(std::make_unique<Jit::Impl>(this, conf)) {}
 
 Jit::~Jit() = default;
 

src/frontend/A64/decoder/a64.inc

@@ -64,7 +64,7 @@ INST(SEVL,                   "SEVL",                                      "11010
 INST(CLREX,                  "CLREX",                                     "11010101000000110011MMMM01011111")
 INST(DSB,                    "DSB",                                       "11010101000000110011MMMM10011111")
 INST(DMB,                    "DMB",                                       "11010101000000110011MMMM10111111")
-//INST(ISB,                    "ISB",                                       "11010101000000110011MMMM11011111")
+INST(ISB,                    "ISB",                                       "11010101000000110011MMMM11011111")
 //INST(SYS,                    "SYS",                                       "1101010100001oooNNNNMMMMooottttt")
 INST(MSR_reg,                "MSR (register)",                            "110101010001poooNNNNMMMMooottttt")
 //INST(SYSL,                   "SYSL",                                      "1101010100101oooNNNNMMMMooottttt")

src/frontend/A64/ir_emitter.cpp

@@ -57,6 +57,10 @@ void IREmitter::DataMemoryBarrier() {
     Inst(Opcode::A64DataMemoryBarrier);
 }
 
+void IREmitter::InstructionSynchronizationBarrier() {
+    Inst(Opcode::A64InstructionSynchronizationBarrier);
+}
+
 IR::U32 IREmitter::GetCNTFRQ() {
     return Inst<IR::U32>(Opcode::A64GetCNTFRQ);
 }

src/frontend/A64/ir_emitter.h

@@ -45,6 +45,7 @@ public:
     void DataCacheOperationRaised(DataCacheOperation op, const IR::U64& value);
     void DataSynchronizationBarrier();
     void DataMemoryBarrier();
+    void InstructionSynchronizationBarrier();
     IR::U32 GetCNTFRQ();
     IR::U64 GetCNTPCT(); // TODO: Ensure sub-basic-block cycle counts are updated before this.
     IR::U32 GetCTR();

src/frontend/A64/translate/impl/system.cpp

@@ -71,6 +71,13 @@ bool TranslatorVisitor::DMB(Imm<4> /*CRm*/) {
     return true;
 }
 
+bool TranslatorVisitor::ISB(Imm<4> /*CRm*/) {
+    ir.InstructionSynchronizationBarrier();
+    ir.SetPC(ir.Imm64(ir.current_location->PC() + 4));
+    ir.SetTerm(IR::Term::ReturnToDispatch{});
+    return false;
+}
+
 bool TranslatorVisitor::MSR_reg(Imm<1> o0, Imm<3> op1, Imm<4> CRn, Imm<4> CRm, Imm<3> op2, Reg Rt) {
     const auto sys_reg = concatenate(Imm<1>{1}, o0, op1, CRn, CRm, op2).ZeroExtend<SystemRegisterEncoding>();
     switch (sys_reg) {

src/frontend/ir/microinstruction.cpp

@@ -395,19 +395,20 @@ bool Inst::IsCoprocessorInstruction() const {
 }
 
 bool Inst::MayHaveSideEffects() const {
-    return op == Opcode::PushRSB                        ||
+    return op == Opcode::PushRSB                              ||
-           op == Opcode::A64SetCheckBit                 ||
+           op == Opcode::A64SetCheckBit                       ||
-           op == Opcode::A64DataCacheOperationRaised    ||
+           op == Opcode::A64DataCacheOperationRaised          ||
-           op == Opcode::A64DataSynchronizationBarrier  ||
+           op == Opcode::A64DataSynchronizationBarrier        ||
-           op == Opcode::A64DataMemoryBarrier           ||
+           op == Opcode::A64DataMemoryBarrier                 ||
-           CausesCPUException()                         ||
+           op == Opcode::A64InstructionSynchronizationBarrier ||
-           WritesToCoreRegister()                       ||
+           CausesCPUException()                               ||
-           WritesToSystemRegister()                     ||
+           WritesToCoreRegister()                             ||
-           WritesToCPSR()                               ||
+           WritesToSystemRegister()                           ||
-           WritesToFPCR()                               ||
+           WritesToCPSR()                                     ||
-           WritesToFPSR()                               ||
+           WritesToFPCR()                                     ||
-           AltersExclusiveState()                       ||
+           WritesToFPSR()                                     ||
-           IsMemoryWrite()                              ||
+           AltersExclusiveState()                             ||
+           IsMemoryWrite()                                    ||
            IsCoprocessorInstruction();
 }
 

src/frontend/ir/opcodes.inc

@@ -66,6 +66,7 @@ A64OPC(ExceptionRaised,                         T::Void,        T::U64,
 A64OPC(DataCacheOperationRaised,                T::Void,        T::U64,         T::U64                          )
 A64OPC(DataSynchronizationBarrier,              T::Void,                                                        )
 A64OPC(DataMemoryBarrier,                       T::Void,                                                        )
+A64OPC(InstructionSynchronizationBarrier,       T::Void,                                                        )
 A64OPC(GetCNTFRQ,                               T::U32,                                                         )
 A64OPC(GetCNTPCT,                               T::U64,                                                         )
 A64OPC(GetCTR,                                  T::U32,                                                         )